feat(kuma-dp) retry connection to the DP/fetching bootstrap #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
| @@ -122,7 +122,6 @@ func (cm *manager) startLeaderComponents(stop <-chan struct{}, errCh chan error) | |||
| closeLeaderCh() | |||
| }, | |||
| }) | |||
| log.Info("Starting leader election") | |||
There was a problem hiding this comment.
Moved this log to Postgres implementation. Otherwise on Kuma DP logs was starting leader election
lobkovilya
reviewed
Aug 18, 2020
app/kuma-dp/cmd/run.go
Outdated
| }) | ||
|
|
||
| if err != nil { | ||
| return nil, errors.Wrap(err, "could retrieve catalog") |
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
approved these changes
Aug 21, 2020
nickolaev
pushed a commit
that referenced
this pull request
Oct 6, 2020
…982) Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> # Conflicts: # app/kuma-dp/cmd/run.go Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds retry for two situations
Used https://github.com/sethvargo/go-retry library which has no additional dependencies. API is kind of meh, but the functionality is simple enough for our needs.
Issues resolved
Fix #968
Documentation