feat(kuma-cp) compile Kuma with custom Runtime and Bootstrap plugins #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…lugins Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
lobkovilya
reviewed
Aug 4, 2020
| for name, plugin := range core_plugins.Plugins().BootstrapPlugins() { | ||
| if (cfg.Environment == config_core.KubernetesEnvironment && name == core_plugins.Universal) || | ||
| (cfg.Environment == config_core.UniversalEnvironment && name == core_plugins.Kubernetes) { | ||
| continue |
There was a problem hiding this comment.
why it is not an error or panic?
There was a problem hiding this comment.
Because we go through all plugins. We want to skip kubernetes plugin on universal and universal plugin on kubernetes. Probably a better way to do it would be to have a list of plugins to load and refactor all plugins to load in such way, but I don't have time for it for now
| @@ -30,11 +30,13 @@ const ( | |||
|
|
|||
| type Registry interface { | |||
| Bootstrap(PluginName) (BootstrapPlugin, error) | |||
| BootstrapPlugins() map[PluginName]BootstrapPlugin | |||
There was a problem hiding this comment.
Do we still need Bootstrap(PluginName) and Runtime(PluginName)?
There was a problem hiding this comment.
Left it out of the convention, I can remove it
lobkovilya
approved these changes
Aug 4, 2020
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kuma: 0.7.0instead of0.7.0