chore(kuma-cp) Use go structs instead of gotemplate for bootstrap (backport #3156) #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
) We were using a yaml template for generating a protobuf that was then validated and serialized back to yaml. We now create directly the protobuf object. This makes the code statically checked and increases performance of bootstrap Also simplify the bootstrap code by inlining some methods Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 8d366db)
Codecov Report
@@ Coverage Diff @@
## release-1.4 #3173 +/- ##
===============================================
+ Coverage 52.23% 52.42% +0.18%
===============================================
Files 923 924 +1
Lines 53629 53836 +207
===============================================
+ Hits 28015 28224 +209
+ Misses 23399 23396 -3
- Partials 2215 2216 +1
Continue to review full report at Codecov.
|
michaelbeaumont
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3156 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com