-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kuma-cp) enable secrets support for Gateway resources #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2953 +/- ##
==========================================
- Coverage 52.37% 52.29% -0.09%
==========================================
Files 912 912
Lines 52584 52723 +139
==========================================
+ Hits 27542 27571 +29
- Misses 22849 22954 +105
- Partials 2193 2198 +5
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Oct 20, 2021
Add the secrets generator to the Gateway proxy template. This fixes mTLS between the gageway proxy and upstream services in the mesh. Signed-off-by: James Peach <james.peach@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
Add the secrets generator to the Gateway proxy template. This fixes mTLS between the gageway proxy and upstream services in the mesh. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 68d5186) # Conflicts: # test/framework/interface.go # test/framework/kumactl.go # test/framework/universal_cluster.go
jpeach
added a commit
that referenced
this pull request
Oct 25, 2021
Add the secrets generator to the Gateway proxy template. This fixes mTLS between the gageway proxy and upstream services in the mesh. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 68d5186)
jpeach
added a commit
that referenced
this pull request
Oct 25, 2021
) Add the secrets generator to the Gateway proxy template. This fixes mTLS between the gageway proxy and upstream services in the mesh. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 68d5186) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the secrets generator to the Gateway proxy template. This fixes
mTLS between the gateway proxy and upstream services in the mesh.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.