Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp) add CP config to ZoneInsights #2661

Merged
merged 1 commit into from
Aug 25, 2021
Merged

feat(kuma-cp) add CP config to ZoneInsights #2661

merged 1 commit into from
Aug 25, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Add Zone CP config to ZoneInsights

Full changelog

  • Add a new field in ZoneInsights called config
  • Add config to KDS DiscoveryRequest Metadata
  • Change the check if the zone is online through inspect zones
  • Add a check that inspect zones returns kubernetes

Issues resolved

No issues.

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • It is backwards compatible, but we won't backport it.

@jakubdyszkiewicz
feat(kuma-cp) add CP config to ZoneInsights
6831018 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 24, 2021 14:17
bartsmykla
bartsmykla approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartsmykla bartsmykla merged commit 5af5cf0 into master Aug 25, 2021
@bartsmykla bartsmykla deleted the feat/cp-config-zone-insights branch August 25, 2021 04:59
mergify bot pushed a commit that referenced this pull request Aug 25, 2021
@jakubdyszkiewicz
feat(kuma-cp) add CP config to ZoneInsights (#2661)
27248da 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 5af5cf0)
@mergify mergify bot mentioned this pull request Aug 25, 2021
Merged
bartsmykla pushed a commit that referenced this pull request Aug 25, 2021
@mergify @jakubdyszkiewicz
feat(kuma-cp) add CP config to ZoneInsights (#2661) (#2669)
c282573 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 5af5cf0)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
@jakubdyszkiewicz @nikita15p
feat(kuma-cp) add CP config to ZoneInsights (kumahq#2661)
6107933 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
@jakubdyszkiewicz @nikita15p
feat(kuma-cp) add CP config to ZoneInsights (kumahq#2661)
1a4c6fd 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @bartsmykla