chore(*) improve resource manager initialization readability #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Peach <james.peach@konghq.com>
lobkovilya
approved these changes
Jul 6, 2021
| @@ -28,6 +32,9 @@ type customizableResourceManager struct { | |||
| } | |||
|
|
|||
| func (m *customizableResourceManager) Customize(resourceType model.ResourceType, manager ResourceManager) { | |||
| if _, ok := m.customManagers[resourceType]; ok { | |||
| panic(fmt.Sprintf("resource type %q is already customized", resourceType)) | |||
There was a problem hiding this comment.
I'd better panicked with error rather than string
There was a problem hiding this comment.
There needs to be a possibility to override existing resource managers. So
- Remove the check
- Add CustomizeOpts and Override()
- Add different method called
Override(resourceType model.ResourceType, manager ResourceManager)
I'm fine with whatever is picked.
Codecov Report
@@ Coverage Diff @@
## master #2316 +/- ##
==========================================
+ Coverage 50.78% 51.14% +0.36%
==========================================
Files 870 874 +4
Lines 40541 40589 +48
==========================================
+ Hits 20587 20759 +172
+ Misses 17959 17806 -153
- Partials 1995 2024 +29
Continue to review full report at Codecov.
|
jakubdyszkiewicz
requested changes
Jul 6, 2021
| @@ -28,6 +32,9 @@ type customizableResourceManager struct { | |||
| } | |||
|
|
|||
| func (m *customizableResourceManager) Customize(resourceType model.ResourceType, manager ResourceManager) { | |||
| if _, ok := m.customManagers[resourceType]; ok { | |||
| panic(fmt.Sprintf("resource type %q is already customized", resourceType)) | |||
There was a problem hiding this comment.
There needs to be a possibility to override existing resource managers. So
- Remove the check
- Add CustomizeOpts and Override()
- Add different method called
Override(resourceType model.ResourceType, manager ResourceManager)
I'm fine with whatever is picked.
Signed-off-by: James Peach <james.peach@konghq.com>
jakubdyszkiewicz
approved these changes
Jul 9, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 544cd03)
lobkovilya
pushed a commit
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactoring is a bit gratuitous, so I'm not that concerned if we don't want to merge it :-)
I was reading the resource manager setup and it was confusing how the type map was still being initialized after already being "consumed" by customizable resource manager.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing