Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-dp) add coredns server to kuma-dp #1811

Merged
merged 5 commits into from
Apr 14, 2021
Merged

feat(kuma-dp) add coredns server to kuma-dp #1811

merged 5 commits into from
Apr 14, 2021

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Apr 14, 2021 •
edited
Loading

Summary

  • Functionality to run DNS Server (CoreDNS) alongside kuma-dp
  • Added to our current build/release workflow building our version of coredns which was stripped from any unnecessary plugins

@bartsmykla
feat(kuma-dp) add functionality to run dns server
04103ce 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
feat(*) add building coredns to workflow
cdd4a64 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
chore(*) make check results
3317792 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner April 14, 2021 11:12
@bartsmykla
chore(kuma-dp) add few more logs in dns server
56f7e02 
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
fix(test) kuma-dp config_test fix
cfd6103 
Signed-off-by: Bart Smykla <bartek@smykla.com>
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid 🆗

@bartsmykla bartsmykla merged commit 49c85ea into kumahq:master Apr 14, 2021
@bartsmykla bartsmykla deleted the feat/coredns-server branch April 14, 2021 12:35
mergify bot pushed a commit that referenced this pull request Apr 14, 2021
@bartsmykla
feat(kuma-dp) add coredns server to kuma-dp (#1811)
aa2515c 
* feat(kuma-dp) add functionality to run dns server

Signed-off-by: Bart Smykla <bartek@smykla.com>

* feat(*) add building coredns to workflow

Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit 49c85ea)

# Conflicts:
#	app/kuma-dp/cmd/run.go
#	pkg/config/app/kuma-dp/config.go
#	pkg/config/app/kuma-dp/config_test.go
#	pkg/config/app/kuma-dp/testdata/default-config.golden.yaml
@mergify mergify bot mentioned this pull request Apr 14, 2021
Merged
nickolaev pushed a commit that referenced this pull request Apr 15, 2021
@bartsmykla
feat(kuma-dp) add coredns server to kuma-dp (#1811)
fe0ea9b 
* feat(kuma-dp) add functionality to run dns server

Signed-off-by: Bart Smykla <bartek@smykla.com>

* feat(*) add building coredns to workflow

Signed-off-by: Bart Smykla <bartek@smykla.com>
nickolaev pushed a commit that referenced this pull request Apr 15, 2021
@mergify @bartsmykla
feat(kuma-dp) add coredns server to kuma-dp (#1811) (#1815)
2eb46e3 
* feat(kuma-dp) add functionality to run dns server

Signed-off-by: Bart Smykla <bartek@smykla.com>

* feat(*) add building coredns to workflow

Signed-off-by: Bart Smykla <bartek@smykla.com>

Co-authored-by: Bart Smykla <bartek@smykla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartsmykla @jakubdyszkiewicz @nickolaev