feat(kuma-cp) sidecar env vars override #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
approved these changes
Feb 15, 2021
bartsmykla
approved these changes
Feb 15, 2021
Co-authored-by: Bart Smykla <bartek@smykla.com>
lobkovilya
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to configure any setting in Kuma DP sidecar.
In case of Universal, a user is responsible for starting Kuma DP in their environment so they can customize cli args and env vars.
In case of Kubernetes, Kuma Injector is injecting sidecar so it's harder to customize setting of sidecar itself. With this PR there are two ways to do it
Global way that applies to all sidecars
There is a new setting called "KUMA_RUNTIME_KUBERNETES_INJECTOR_SIDECAR_CONTAINER_ENV_VARS" that you can provide list of ENV_VARS that will be applied on all sidecars
Override setting of one sidecar
There is a new annotation called
kuma.io/sidecar-env-varsthat can override setting for individual sidecar.Documentation