chore(*) support Service-less Pods #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
feat/support_serviceless_pods
branch
from
f4edfbb to
e48386c
Compare
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
There was a problem hiding this comment.
Nice, two questions.
- In inbound proxy generator, should we skip generating inbound listener when port is
TCPPortReserved. It will save us and Envoy some cycles and this listener cannot be used anyways - Please make sure in the docs to communicate to users that this requirement of Service = Pod is no longer true and the name can be autogenerated from the Pod. In the GUI, I'd also leave some mark to the docs since users might be confused why some names are from 1 template and one from the other template.
| // Notice that here we return an error immediately | ||
| // instead of leaving Dataplane validation up to a ValidatingAdmissionWebHook. | ||
| // We do it this way in order to provide the most descriptive error message. | ||
| return nil, errors.Errorf("Kuma requires every Pod in a Mesh to be a part of at least one Service. However, this Pod doesn't have any container ports that would satisfy matching Service(s).") |
There was a problem hiding this comment.
The first sentence is no longer true
added 6 commits
January 27, 2021 14:09
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
| @@ -357,7 +357,7 @@ var _ = Describe("PodToDataplane(..)", func() { | |||
| port: 6060 | |||
| targetPort: diagnostics | |||
| `}, | |||
| expectedErr: `Kuma requires every Pod in a Mesh to be a part of at least one Service. However, this Pod doesn't have any container ports that would satisfy matching Service(s).`, | |||
| expectedErr: `A service that selects pod example was bound, but it doesn't match any container ports.`, | |||
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
jakubdyszkiewicz
approved these changes
Jan 29, 2021
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2021
* chore(*) support Service-less Pods * fix(*) test e2e * fix(*) outbound converter handles service less * fix(*) update error message in inbound converter Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit 5c18cb8)
nickolaev
pushed a commit
that referenced
this pull request
Feb 10, 2021
* chore(*) support Service-less Pods * fix(*) test e2e * fix(*) outbound converter handles service less * fix(*) update error message in inbound converter Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com> (cherry picked from commit 5c18cb8) Co-authored-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow for pods without a Service to be part of the mesh (i.e. they will not expose any endpoints).
Documentation