feat(kuma-cp) Add control plane identifier in DiscoveryResponse #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
pkg/core/runtime/builder.go
Outdated
| @@ -70,12 +72,14 @@ type Builder struct { | |||
| } | |||
|
|
|||
| func BuilderFor(cfg kuma_cp.Config) *Builder { | |||
| hostname, _ := os.Hostname() | |||
There was a problem hiding this comment.
please do not ignore errors. Change the signature to
func BuilderFor(cfg kuma_cp.Config) (*Builder, error)
…ane-identifier-to-discovery-response Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Dec 23, 2020
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com> (cherry picked from commit 1fbce80)
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Dec 23, 2020
Signed-off-by: Jacek Ewertowski <jacek.ewertowski1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jacek Ewertowski jacek.ewertowski1@gmail.com
Summary
This pull requests adds control plane id callback to callbacks chain in the XDS server.
Issues resolved
Fix #1011