fix(kuma-cp) probes without inbound #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
Nov 23, 2020
| if portSet[endpoint.InboundPort] { | ||
| virtualHostBuilder.Configure( | ||
| envoy_routes.Route(endpoint.Path, endpoint.InboundPath, names.GetLocalClusterName(endpoint.InboundPort), true)) | ||
| } else { |
There was a problem hiding this comment.
would be great to have a comment with an explanation of why. Something like:
On Kubernetes we are overriding probes for every container, but there is no guarantee that given probe will have an equivalent in inbound interface (ex. sidecar that is not selected by any service). In this situation there is no local cluster therefore we are sending redirect to a real destination. System responsible for using virtual probes needs to support redirect (kubelet on K8S supports it).
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
nickolaev
approved these changes
Nov 23, 2020
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2020
Do `redirect` for probes that don't have inbound Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit f458cf0)
nickolaev
pushed a commit
that referenced
this pull request
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do
redirectfor probes that don't have inbound