fix(kuma-cp) fix env #1171
Merged
fix(kuma-cp) fix env #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
nickolaev
reviewed
Nov 19, 2020
|
Yes, I will expand testing |
jakubdyszkiewicz
approved these changes
Nov 19, 2020
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
| } | ||
|
|
||
| Expect(testEnvs).To(Equal(configEnvs)) | ||
| } |
There was a problem hiding this comment.
That's amazing 👏
Please add a message like we have in generate tests
Expect(string(actualContents)).To(Equal(string(given.ExpectedContents)), "generated Go code is no longer in sync with the original template files. To re-generate it, run `make generate/kumactl/install/k8s/control-plane`")
Something like
%s config values are not overridden in the test. Add overrides for them with a value that is different than default.
| if _, exist, _ := metadata.Annotations(pod.Annotations).GetEnabled(metadata.KumaVirtualProbesAnnotation); !exist { | ||
| annotations[metadata.KumaVirtualProbesAnnotation] = metadata.AnnotationEnabled | ||
| if err := virtualProbesEnabled(annotations, pod, i.cfg); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
please change the method names. I was confused why it's not returning bool and what is going on. It should be something like setVirtualProbesEnabledAnnotation, setVirtualProbesPortAnnotation
| if enabled, exist, _ := metadata.Annotations(pod.Annotations).GetEnabled(metadata.KumaGatewayAnnotation); exist && enabled { | ||
| annotations[metadata.KumaVirtualProbesAnnotation] = metadata.AnnotationDisabled | ||
| if err := virtualProbesPort(annotations, pod, i.cfg); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
give more context to these errors
| @@ -0,0 +1,187 @@ | |||
| // Copyright (c) 2013 Kelsey Hightower | |||
There was a problem hiding this comment.
Is this copy paste? Can you also paste the reference here (link to github)?
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
nickolaev
approved these changes
Nov 23, 2020
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2020
(cherry picked from commit 3d02c39)
nickolaev
pushed a commit
that referenced
this pull request
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Lobkov ilya.lobkov@konghq.com
Summary
Fix env