Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp) token bound to DP type #1069

Merged
merged 2 commits into from
Oct 16, 2020
Merged

feat(kuma-cp) token bound to DP type #1069

merged 2 commits into from
Oct 16, 2020

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Oct 13, 2020 •
edited
Loading

Summary

Until now, anybody could change their DP into Ingress Dataplane.

Ingress Dataplane now requires explicit Ingress token

kumactl generate dataplane-token --type=ingress

If type is empty we assume it's regular data plane.

Full changelog

  • Removed duplicated SDS auth and changed it so it depends on XDS auth code

Documentation

@jakubdyszkiewicz
feat(kuma-dp) dataplane token for ingress
756d9bc 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
remove sds auth and move to xds auth
924dff5 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 13, 2020 08:48
@jakubdyszkiewicz jakubdyszkiewicz merged commit c8d2277 into master Oct 16, 2020
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/token-ingress branch October 16, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickolaev nickolaev nickolaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @nickolaev